Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix 2 issues #16183

Merged
merged 2 commits into from
Jan 19, 2024
Merged

fix 2 issues #16183

merged 2 commits into from
Jan 19, 2024

Conversation

hfxsd
Copy link
Collaborator

@hfxsd hfxsd commented Jan 18, 2024

First-time contributors' checklist

What is changed, added or deleted? (Required)

  • Refined a tittle in BR br-pitr-guide
  • Add json in code examples to make them display correctly

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v7.6 (TiDB 7.6 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.4 (TiDB 7.4 versions)
  • v7.3 (TiDB 7.3 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@hfxsd hfxsd added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. ONCALL Relates to documentation oncall. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. labels Jan 18, 2024
@hfxsd hfxsd self-assigned this Jan 18, 2024
@ti-chi-bot ti-chi-bot bot added contribution This PR is from a community contributor. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 18, 2024
@hfxsd hfxsd requested a review from lidezhu January 18, 2024 08:32
@hfxsd hfxsd removed the contribution This PR is from a community contributor. label Jan 18, 2024
lidezhu
lidezhu approved these changes Jan 18, 2024
View reviewed changes
Copy link
Contributor

@lidezhu lidezhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 18, 2024

@lidezhu: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hfxsd hfxsd requested a review from ran-huang January 18, 2024 08:36
benmaoer
benmaoer approved these changes Jan 18, 2024
View reviewed changes
Copy link
Contributor

@benmaoer benmaoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 18, 2024

@benmaoer: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 19, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-19 04:35:18.697109621 +0000 UTC m=+503360.261407319: ☑️ agreed by ran-huang.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jan 19, 2024
@hfxsd hfxsd added the lgtm label Jan 19, 2024
@hfxsd
Copy link
Collaborator Author

hfxsd commented Jan 19, 2024

/approve

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hfxsd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jan 19, 2024
@ti-chi-bot ti-chi-bot bot merged commit 8c93ad4 into pingcap:master Jan 19, 2024
9 checks passed
@ti-chi-bot ti-chi-bot mentioned this pull request Jan 19, 2024
Merged
18 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #16191.

ti-chi-bot bot pushed a commit that referenced this pull request Jan 19, 2024
@ti-chi-bot
fix 2 issues (#16183) (#16191)
fb3a2d2
PitifulPete pushed a commit to PitifulPete/tidb-docs that referenced this pull request Jan 19, 2024
@hfxsd @PitifulPete
fix 2 issues (pingcap#16183)
9874fde
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ran-huang ran-huang ran-huang approved these changes

@lidezhu lidezhu lidezhu approved these changes

@benmaoer benmaoer benmaoer approved these changes

Assignees

@hfxsd hfxsd

Labels
approved lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. ONCALL Relates to documentation oncall. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hfxsd @ti-chi-bot @benmaoer @lidezhu @ran-huang